At the moment, Intel’s Jani Nikula, a Linux Software program engineer on the firm, responded to Linux boss Linus Torvalds to oblige and rectify the problems that had been identified. In his humorous response, Nikula talked about hiding all of the “disgusting turds”. He wrote:
Cover all of the disgusting turds in .hdrtest subdirectories within the construct tree, and put the additional drm build-time checks behind a kconfig choice.
For context, Linus Torvalds, within the basic Linus Torvalds style, gave a grumpy rant a couple of latest pull request by Nikula because it was sub-optimal. The change was associated to the Direct Rendering Supervisor (DRM) of the Linux kernel for Intel Xe graphics drivers. The Direct Rendering Supervisor (DRM) in Linux is a kernel subsystem managing GPUs for graphics rendering. It helps with duties like {hardware} acceleration, video playback, and 3D rendering.
Torvalds had identified that the header check recordsdata (hdrtest) would decelerate your complete kernel configuration construct, plus additionally depart ineffective and pointless recordsdata there as a consequence. Thus, Torvalds prompt that this be separated.
He wrote:
Grr. I did the pull, resolved the (trivial) conflicts, however I discover that this ended up containing the disgusting “hdrtest” crap that
(a) slows down the construct as a result of it is carried out for a daily allmodconfig construct somewhat than be some easy factor that you just guys can run as wanted
(b) additionally leaves random ‘hdrtest’ turds round within the embody directories
Folks already complained individually about this. It ought to by no means have made it to me on this damaged kind.
Why the heck is that this testing being carried out as a daily a part of the construct?
And dammit we do not add random turd recordsdata for dependencies that then make the supply tree nasty.
The factor that made me discover that it was nonetheless there was that “git standing” complains concerning the silly turds not being ignored.
However extra importantly, these turds additionally break filename completion! So no, including it to gitignore would not truly repair the issue, it might simply have made me not discover as rapidly.
This factor must *die*.
If you wish to do this hdrtest factor, do it as a part of your *personal* checks. Do not make everyone else see that disgusting factor and have these turds of their bushes.
I am going to simply disable it by marking it BROKEN for now. You guys can determine what you need to do, however no, forcing others to see these issues is just not the reply.
I might recommend you *not* make this a part of the Kconfig setup and regular construct in any respect, however be one thing the place *you* can run it as a part of your assessments (ie do it as a “make drm-hdrtest” type of factor, not as a part of common builds).
Linus
You may view the messages on the supply hyperlinks under on the Linux Kernel Mailing Checklist (LKML) web site.
No Comment! Be the first one.